Re: [PATCH v3 4/7] selinux: make left shifts well defined

From: Paul Moore
Date: Wed Aug 09 2023 - 19:07:52 EST


On Aug 7, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@xxxxxxxxxxxxxx> wrote:
>
> The loops upper bound represent the number of permissions used (for the
> current class or in general). The limit for this is 32, thus we might
> left shift of one less, 31. Shifting a base of 1 results in undefined
> behavior; use (u32)1 as base.
>
> Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
> ---
> v3: split from parent commit and apply cast to correct shift operand
> ---
> security/selinux/ss/services.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Merged into selinux/next, thanks.

--
paul-moore.com