Re: [PATCH] net/llc/llc_conn.c: fix 4 instances of -Wmissing-variable-declarations

From: patchwork-bot+netdevbpf
Date: Wed Aug 09 2023 - 19:00:29 EST


Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Tue, 08 Aug 2023 09:43:09 -0700 you wrote:
> I'm looking to enable -Wmissing-variable-declarations behind W=1. 0day
> bot spotted the following instances:
>
> net/llc/llc_conn.c:44:5: warning: no previous extern declaration for
> non-static variable 'sysctl_llc2_ack_timeout'
> [-Wmissing-variable-declarations]
> 44 | int sysctl_llc2_ack_timeout = LLC2_ACK_TIME * HZ;
> | ^
> net/llc/llc_conn.c:44:1: note: declare 'static' if the variable is not
> intended to be used outside of this translation unit
> 44 | int sysctl_llc2_ack_timeout = LLC2_ACK_TIME * HZ;
> | ^
> net/llc/llc_conn.c:45:5: warning: no previous extern declaration for
> non-static variable 'sysctl_llc2_p_timeout'
> [-Wmissing-variable-declarations]
> 45 | int sysctl_llc2_p_timeout = LLC2_P_TIME * HZ;
> | ^
> net/llc/llc_conn.c:45:1: note: declare 'static' if the variable is not
> intended to be used outside of this translation unit
> 45 | int sysctl_llc2_p_timeout = LLC2_P_TIME * HZ;
> | ^
> net/llc/llc_conn.c:46:5: warning: no previous extern declaration for
> non-static variable 'sysctl_llc2_rej_timeout'
> [-Wmissing-variable-declarations]
> 46 | int sysctl_llc2_rej_timeout = LLC2_REJ_TIME * HZ;
> | ^
> net/llc/llc_conn.c:46:1: note: declare 'static' if the variable is not
> intended to be used outside of this translation unit
> 46 | int sysctl_llc2_rej_timeout = LLC2_REJ_TIME * HZ;
> | ^
> net/llc/llc_conn.c:47:5: warning: no previous extern declaration for
> non-static variable 'sysctl_llc2_busy_timeout'
> [-Wmissing-variable-declarations]
> 47 | int sysctl_llc2_busy_timeout = LLC2_BUSY_TIME * HZ;
> | ^
> net/llc/llc_conn.c:47:1: note: declare 'static' if the variable is not
> intended to be used outside of this translation unit
> 47 | int sysctl_llc2_busy_timeout = LLC2_BUSY_TIME * HZ;
> | ^
>
> [...]

Here is the summary with links:
- net/llc/llc_conn.c: fix 4 instances of -Wmissing-variable-declarations
https://git.kernel.org/netdev/net-next/c/fa1891aeb762

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html