Re: [PATCH] rust: macros: add `paste!` proc macro

From: Miguel Ojeda
Date: Wed Aug 09 2023 - 18:29:21 EST


On Thu, Aug 10, 2023 at 12:02 AM Gary Guo <gary@xxxxxxxxxxx> wrote:
>
> Sorry I forgot to add license comments!

No problem at all :)

> All my kernel contributions are permissively licensed if possible, so I
> am fine with this being either MIT or GPL-2.0 (I think GPL-2.0 is
> deprecated in as a SPDX license identifier and it should be
> GPL-2.0-only going forward, though).

Yeah, the 3.0 version of the SPDX license list deprecated `GPL-2.0`,
but the kernel still allows `GPL-2.0` and lists it first. I recall
thinking about this before the initial merge, and I think I went with
the original form because the main `COPYING` file still uses that.
After that I am just keeping it consistent, though I am not sure when
the kernel will migrate.

> Given this is non-kernel specific generic code, I think it might worth
> following the convention of the paste and pin-init code and make it
> `Apache-2.0 OR MIT`? This would also make it the same license as the
> `paste` crate (although we don't have to keep the same license as this
> is a different implementation).
>
> I'll leave the final decision to you.

Since you prefer it and it makes sense that someone may want to use it
(`concat` and `expand`) elsewhere, let's go with that. I will add:

// SPDX-License-Identifier: Apache-2.0 OR MIT

then. Thanks for the very quick reply!

Cheers,
Miguel