Re: [PATCH v2 2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm_init

From: Bao D. Nguyen
Date: Wed Aug 09 2023 - 18:12:13 EST


On 8/9/2023 12:10 PM, Brian Masney wrote:
Convert ufshcd_pltfrm_init() over to use dev_err_probe() to avoid
the following log message on bootup due to an -EPROBE_DEFER return
code:

ufshcd-qcom 1d84000.ufs: Initialization failed

Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>
---
No changes since v1

drivers/ufs/host/ufshcd-pltfrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c
index 0b7430033047..f2c50b78efbf 100644
--- a/drivers/ufs/host/ufshcd-pltfrm.c
+++ b/drivers/ufs/host/ufshcd-pltfrm.c
@@ -373,7 +373,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
err = ufshcd_init(hba, mmio_base, irq);
if (err) {
- dev_err(dev, "Initialization failed\n");
+ dev_err_probe(dev, err, "Initialization failed\n");
Hi Brian,
Can you pls add the error code to the print?

goto dealloc_host;
}