Re: [PATCH RESEND] tty: serial: qcom-geni-serial: Poll primary sequencer irq status after cancel_tx

From: Bryan O'Donoghue
Date: Wed Aug 09 2023 - 15:40:15 EST


On 09/08/2023 13:11, Vijaya Krishna Nivarthi wrote:
While at it, also remove a couple of redundant lines that read from IRQ_EN
register and write back same.

Fixes: 2aaa43c70778 ("tty: serial: qcom-geni-serial: add support for serial engine DMA")
Signed-off-by: Vijaya Krishna Nivarthi<quic_vnivarth@xxxxxxxxxxx>

The "while at it" should be put into a separate patch.

I wonder if the read/write cycle is there to ensure an io-completion ?

Either way please break this up into two individual patches. One thing changing where you poll and the other removing the read/write cycle, so the changes may be evaluated individually.

---
bod