Re: [PATCH v3] tun: avoid high-order page allocation for packet header

From: Erdogan, Tahsin
Date: Wed Aug 09 2023 - 11:01:40 EST


On Wed, 2023-08-09 at 10:01 -0400, Willem de Bruijn wrote:
> Erdogan, Tahsin wrote:
> > On Wed, 2023-08-09 at 09:18 -0400, Willem de Bruijn wrote:
> > > Tun sendmsg is a special case, only used by vhost-net from inside
> > > the
> > > kernel. Arguably consistency with packet_snd/packet_alloc_skb
> > > would
> > > be
> > > more important. That said, this makes sense to me. I assume your
> > > configuring a device with very large MTU?
> >
> > That's right. I am setting MTU to 9100 in my test.
>
> Makes sense. That's not even that large.
>
> Please address the commit message points about virtio_net_hdr.hdr_len
> and write() vs writev().

Yes, I will update commit message in v4. thank you.