Re: [PATCH v2] riscv: mm: fix 2 instances of -Wmissing-variable-declarations

From: patchwork-bot+linux-riscv
Date: Wed Aug 09 2023 - 10:40:34 EST


Hello:

This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <palmer@xxxxxxxxxxxx>:

On Tue, 08 Aug 2023 09:35:00 -0700 you wrote:
> I'm looking to enable -Wmissing-variable-declarations behind W=1. 0day
> bot spotted the following instance in ARCH=riscv builds:
>
> arch/riscv/mm/init.c:276:7: warning: no previous extern declaration
> for non-static variable 'trampoline_pg_dir'
> [-Wmissing-variable-declarations]
> 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
> | ^
> arch/riscv/mm/init.c:276:1: note: declare 'static' if the variable is
> not intended to be used outside of this translation unit
> 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
> | ^
> arch/riscv/mm/init.c:279:7: warning: no previous extern declaration
> for non-static variable 'early_pg_dir'
> [-Wmissing-variable-declarations]
> 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE);
> | ^
> arch/riscv/mm/init.c:279:1: note: declare 'static' if the variable is
> not intended to be used outside of this translation unit
> 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE);
> | ^
>
> [...]

Here is the summary with links:
- [v2] riscv: mm: fix 2 instances of -Wmissing-variable-declarations
https://git.kernel.org/riscv/c/d2402048bc8a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html