Re: [PATCH] perf/smmuv3: Add platform id table for module auto loading

From: Barry Song
Date: Wed Aug 09 2023 - 01:47:48 EST


On Wed, Aug 9, 2023 at 1:01 PM Liang Li <liliang6@xxxxxxxx> wrote:
>
> On 2023-08-07 20:22, Yicong Yang <yangyicong@xxxxxxxxxx> wrote:
> > From: Yicong Yang <yangyicong@xxxxxxxxxxxxx>
> >
> > On ACPI based system the device is probed by the name directly. If the
> > driver is configured as module it can only be loaded manually. Add the
> > platform id table as well as the module alias then the driver will be
> > loaded automatically by the udev or others once the device added.
> >
>
> Please consider revise the long log to clearly express the purpose of the
> changes in this patch:
>
> - What's the exact issue the patch is addressing
> - Why the changes in this patch can fix the issue or make something working
> - Consider impact of the changes introduced by this patch
>
> These info may help reviewers and maintainers .. and yourself on code merge.

years ago, i found a good doc regarding this,
https://wiki.archlinux.org/title/Modalias

guess it is because /lib/modules/$(uname -r)/modules.alias fails to contain smmu
driver without the MODULE_DEVICE_TABLE, isn't it, yicong?

>
> Regards.
>

Thanks
Barry