Re: [PATCH] x86/linkage: Fix typo of BUILD_VDSO in asm/linkage.h

From: Randy Dunlap
Date: Tue Aug 08 2023 - 17:05:01 EST




On 8/8/23 11:23, Jinghao Jia wrote:
> The BUILD_VDSO macro was incorrectly spelled as BULID_VDSO in
> asm/linkage.h. This causes the !defined(BULID_VDSO) directive to always
> evaluate to true.
>
> Correct the spelling to BUILD_VDSO.
>
> Fixes: bea75b33895f ("x86/Kconfig: Introduce function padding")
> Signed-off-by: Jinghao Jia <jinghao@xxxxxxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
> arch/x86/include/asm/linkage.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/linkage.h b/arch/x86/include/asm/linkage.h
> index 0953aa32a324..97a3de7892d3 100644
> --- a/arch/x86/include/asm/linkage.h
> +++ b/arch/x86/include/asm/linkage.h
> @@ -21,7 +21,7 @@
> #define FUNCTION_PADDING
> #endif
>
> -#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BULID_VDSO)
> +#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO)
> # define __FUNC_ALIGN __ALIGN; FUNCTION_PADDING
> #else
> # define __FUNC_ALIGN __ALIGN

--
~Randy