Re: [PATCH] vboxsf: Use flexible arrays for trailing string member

From: Kees Cook
Date: Tue Aug 08 2023 - 17:02:14 EST


On Tue, Aug 08, 2023 at 02:20:06PM -0500, Larry Finger wrote:
> On 7/26/23 16:55, Kees Cook wrote:
> >
> > On Thu, 20 Jul 2023 08:15:06 -0700, Kees Cook wrote:
> > > The declaration of struct shfl_string used trailing fake flexible arrays
> > > for the string member. This was tripping FORTIFY_SOURCE since commit
> > > df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3"). Replace the
> > > utf8 and utf16 members with actual flexible arrays, drop the unused ucs2
> > > member, and retriain a 2 byte padding to keep the structure size the same.
> > >
> > >
> > > [...]
> >
> > Applied to for-linus/hardening, thanks!
> >
> > [1/1] vboxsf: Use flexible arrays for trailing string member
> > https://git.kernel.org/kees/c/a8f014ec6a21
>
> Kees,
>
> This patch has not been applied to kernel 6.5-rc5. Is there some problem?

Hi! Sorry, I was waiting for linux-next testing, and then got distracted
on Friday. I will send the PR to Linus today.

Thanks for the poke!

-Kees

--
Kees Cook