Re: [PATCH net-next 04/10] mlx4: Get rid of the mlx4_interface.activate callback

From: Leon Romanovsky
Date: Tue Aug 08 2023 - 16:36:06 EST


On Fri, Aug 04, 2023 at 05:05:21PM +0200, Petr Pavlu wrote:
> The mlx4_interface.activate callback was introduced in commit
> 79857cd31fe7 ("net/mlx4: Postpone the registration of net_device"). It
> dealt with a situation when a netdev notifier received a NETDEV_REGISTER
> event for a new net_device created by mlx4_en but the same device was
> not yet visible to mlx4_get_protocol_dev(). The callback can be removed
> now that mlx4_get_protocol_dev() is gone.
>
> Signed-off-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
> Tested-by: Leon Romanovsky <leon@xxxxxxxxxx>
> ---
> drivers/net/ethernet/mellanox/mlx4/en_main.c | 37 +++++++++-----------
> drivers/net/ethernet/mellanox/mlx4/intf.c | 2 --
> include/linux/mlx4/driver.h | 1 -
> 3 files changed, 16 insertions(+), 24 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>