Re: [PATCH libnvme v2 2/2] fabrics: Do not pass disable_sqflow if not supported

From: Daniel Wagner
Date: Tue Aug 08 2023 - 13:41:35 EST


On Tue, Aug 08, 2023 at 11:47:14AM +0300, Sagi Grimberg wrote:
> I think you want to check this before the initial call
> and avoid the retry altogether.
> --
> - if (e->treq & NVMF_TREQ_DISABLE_SQFLOW)
> + if (e->treq & NVMF_TREQ_DISABLE_SQFLOW &&
> + nvmf_check_option(h->r, disable_sqflow))
> c->cfg.disable_sqflow = true;
> + else
> + c->cfg.disable_sqflow = false;
>
> if (e->trtype == NVMF_TRTYPE_TCP &&
> (e->treq & NVMF_TREQ_REQUIRED ||

Yep, makes sense.