Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

From: Linus Walleij
Date: Tue Aug 08 2023 - 13:32:12 EST


On Mon, Aug 7, 2023 at 3:10 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Mon, Aug 07, 2023 at 03:05:15PM +0200, Linus Walleij wrote:
> > On Wed, Jul 26, 2023 at 5:04 PM Herve Codina <herve.codina@xxxxxxxxxxx> wrote:
>
> > > +#include "linux/bitfield.h"
>
> > Really? I don't think there is such a file there.
>
> > Do you mean <linux/bitfield.h> and does this even compile?
>
> #include "" means "try the local directory first then fall back to
> system includes" so it'll work, it picks up extra stuff on top of what
> <> does. There's a stylistic issue though.

Wow that's a neat trick, I learn something new every day!

But we probably wanna be sure to get the system include.

Yours,
Linus Walleij