Re: [PATCH v9 2/7] nvmem: core: Return NULL when no nvmem layout is found

[Michael Walle]

Am 2023-08-08 08:29, schrieb Miquel Raynal:
> Currently, of_nvmem_layout_get_container() returns NULL on error, or an
> error pointer if either CONFIG_NVMEM or CONFIG_OF is turned off. We
> should likely avoid this kind of mix for two reasons: to clarify the
> intend and anyway fix the !CONFIG_OF which will likely always if we use
> this helper somewhere else. Let's just return NULL when no layout is
> found, we don't need an error value here.
>
> Link: 
> https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/
> Fixes: 266570f496b9 ("nvmem: core: introduce NVMEM layouts")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/r/202308030002.DnSFOrMB-lkp@xxxxxxxxx/
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Reviewed-by: Michael Walle <michael@xxxxxxxx>