Re: [RFC 0/1] mips: malta: Select PCI_QUIRKS if POWER_RESET_PIIX4_POWEROFF is enabled

From: Maciej W. Rozycki
Date: Tue Aug 08 2023 - 12:46:11 EST


On Sun, 6 Aug 2023, Zhangjin Wu wrote:

> To simplify the enablement of the poweroff support, selecting the required
> options for CONFIG_POWER_RESET=y may make many people happy especially when
> they are using a customized config (maybe tinyconfig based) for a target qemu
> board. Without normal poweroff support from the kernel side, qemu will simply
> hang there after a 'poweroff' command, which is a very bad experience for the
> automatical tests. Currently, based on tinyconfig, it is very hard to find the
> exact poweroff options, some architectures simply enable poweroff support by
> default, the others' poweroff options are hidden deeply, which make things very
> hard.

The settings are a bit buried indeed and I was hit by that myself at one
point when upgrading the kernel using old .config, but honestly I think we
want to let people strip the kernel from options they don't want or need,
so I think it will best be sorted by presetting the useful options in the
respective defconfigs and then maybe guard the more critical ones with `if
EXPERT'.

Maciej