Re: [PATCH v4 6/8] iommu/arm-smmu-v3: Move CD table to arm_smmu_master

From: Michael Shavit
Date: Mon Aug 07 2023 - 08:20:50 EST

On Fri, Aug 4, 2023 at 2:47 AM Jason Gunthorpe <jgg@xxxxxxxxxx> wrote:
> I'm not surprised, I think arm_smmu_write_ctx is a little too clever
> for its own good..
> I would have written it by computing the full target CD entry,
> extracted directly from the domain.

Yeah I was considering making a fix to arm_smmu_write_ctx instead; but
clearing the CD entry on detach feels like the right thing to do.
Relying on the 0th CD entry being re-written when the CD table is
re-inserted feels fragile.

Perhaps re-writing arm_smmu_write_ctx could be considered as a
separate singleton patch?