Re: [PATCH v2] PCI/DOE: Expose the DOE protocols via sysfs

From: Greg KH
Date: Sat Aug 05 2023 - 01:59:59 EST

On Fri, Aug 04, 2023 at 06:05:42PM +0200, Lukas Wunner wrote:
> On Fri, Aug 04, 2023 at 11:17:59AM -0400, Alistair Francis wrote:
> > On Wed, Aug 2, 2023 at 6:52???PM Lukas Wunner <lukas@xxxxxxxxx> wrote:
> > > I kind of like the approach of exposing a list which can be grep'ed,
> > > even though it may go against the rule of having just one datum per
> > > attribute. I'd prefer a representation that's human-readable though,
> > > e.g. "0001:01" for CMA-SPDM.
> >
> > Yeah, it's my preferred method as well, but it's not going to be
> > accepted upstream
> How about procfs instead of sysfs?

No, procfs is for "processes", not devices.

> No "single datum per file" rule over there.
> PCI content goes into /proc/bus/pci/.
> Already used by lspci to access config space.

And that is old legacy stuff, please, let us learn from our past
mistakes in api creation, sysfs was created this way for a reason (i.e.
large files in procfs do not work well over time.)


greg k-h