RE: [EXT] Re: [PATCH net] octeontx2-pf: Set maximum queue size to 16K

From: Ratheesh Kannoth
Date: Thu Aug 03 2023 - 22:26:20 EST

> From: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
> Sent: Thursday, August 3, 2023 8:37 PM
> To: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>
> Subject: [EXT] Re: [PATCH net] octeontx2-pf: Set maximum queue size to 16K

> > These recycling will impact on performance, right ? else, why didn't page
> pool made this size as constant.
> Page Pool doesn't need huge ptr_ring sizes to successfully recycle pages.
> Especially given that the recent PP optimizations made locking recycling
> happen much more rarely.
Got it. Thanks.

> Re "size as constant" -- because lots of NICs don't need more than 256 or 512
> descriptors and it would be only a waste to create page_pools with huge
> ptr_rings for them. Queue sizes bigger than 1024 (ok, maybe
> 2048) is the moment when the linear scale stops working. That's why I
> believe that going out of [64, 2048] for page_pools doesn't make much
> sense.
So, will clamp to 2048 in page_pool_init() ? But it looks odd to me, as
User requests > 2048, but will never be aware that it is clamped to 2048.
Better do this clamping in Driver and print a warning message ?