Re: [PATCH v4 1/1] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties

From: Nylon Chen
Date: Thu Aug 03 2023 - 05:28:58 EST

Hi Conor,

I apologize for forgetting about this update earlier. Just now,
I tried to pull rebase master and noticed that other developers seem
to have made some fixes to the algorithm. Upon closer inspection, I
found that they addressed the part we previously discussed with Emil
and Uwe, such as "first pwm_apply_state."

Therefore, my instinct tells me that they have already taken care of
the issues we discussed before.

I will review the conflicting parts in the pwm-sifive.c code in my v4
version once again to ensure there are no omissions. If I find any, I
will submit v5 accordingly.

Conor Dooley <conor.dooley@xxxxxxxxxxxxx> 於 2023年8月3日 週四 下午5:19寫道:
> On Thu, Aug 03, 2023 at 04:57:34PM +0800, Nylon Chen wrote:
> > This removes the active-low properties of the PWM-controlled LEDs in
> > the HiFive Unmatched device tree.
> >
> > The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1].
> >
> > Link: [0]
> > Link: [1]
> >
> > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Since there is no PWM driver patch for this to go along with, this ack
> doesn't mean anything anymore. Please drop it if you resubmit.