RE: [PATCH net-next] net: lan743x: skip timestamping for non-PTP packets

From: VishvambarPanth.S
Date: Wed Aug 02 2023 - 23:39:48 EST

Hi Richard,

Thanks for your review comments.
We will work on configuring timestamp based on hwtstamp_config. We will update in the next patch submission.

Vishvambar Panth S

-----Original Message-----
From: Richard Cochran <richardcochran@xxxxxxxxx>
Sent: Monday, July 31, 2023 7:21 PM
To: VishvambarPanth S - I69108 <VishvambarPanth.S@xxxxxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Bryan Whitehead - C21958 <Bryan.Whitehead@xxxxxxxxxxxxx>; UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx
Subject: Re: [PATCH net-next] net: lan743x: skip timestamping for non-PTP packets

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Mon, Jul 31, 2023 at 06:24:18PM +0530, Vishvambar Panth S wrote:
> Currently all the RX packets are timestamped and the timestamp is
> appended to the RX packet for processing, this reduces RX throughput.
> This can be optimized by timestamping packets only when the PTP messages are received.

No, you should not do this unconditionally.

Instead, you need to dial the correct setting based on the hwtstamp_config in lan743x_ptp_ioctl().