Re: [PATCH v2] RISC-V: cpu: refactor deprecated strncpy

From: Palmer Dabbelt
Date: Wed Aug 02 2023 - 16:42:11 EST

On Wed, 02 Aug 2023 13:36:03 PDT (-0700), keescook@xxxxxxxxxxxx wrote:
On Wed, Aug 02, 2023 at 12:21:58AM +0000, Justin Stitt wrote:
`strncpy` is deprecated for use on NUL-terminated destination strings [1].

Favor not copying strings onto stack and instead use strings directly.
This avoids hard-coding sizes and buffer lengths all together.

Cc: linux-hardening@xxxxxxxxxxxxxxx
Suggested-by: Kees Cook <keescook@xxxxxxxxxxxx>
Signed-off-by: Justin Stitt <justinstitt@xxxxxxxxxx>

I like it! ;)

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

Thanks, I just queue it up for fixes (might take a bit to build test, I'm a bit backed up).

Reviewed-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>

If you wanted to take it for some hardening thing, though -- otherwise it'll likely end up on my fixes later today.