Re: [PATCH 0/4] drm/panel: sitronix-st7789v: add support for partial mode

From: Daniel Vetter
Date: Wed Aug 02 2023 - 10:26:05 EST

On Tue, Jul 18, 2023 at 05:31:49PM +0200, Michael Riesch wrote:
> Hi all,
> This series adds support for the partial display mode to the Sitronix
> ST7789V panel driver. This is useful for panels that are partially
> occluded by design, such as the Jasonic JT240MHQS-HWT-EK-E3. Support
> for this particular panel is added as well.
> Note: This series is already based on
> Looking forward to your comments!

Summary of my take from a fairly long (and kinda still on-going) irc

- Where we do know the exact overscan, the kernel should expose correct
modes and adjust the display pipeline to match if needed when
programming the hardware. Meaning the approach in this patch series.

- For hdmi overscan there's a lot of automagic overscan happening by
default. Drivers can mostly fix this by setting all the right
infoframes, but unfortuantely a very big pile of infoframes is needed.
Assuming drivers actually use the helpers I think only i915 gets them
all, so intel_hdmi_compute_config() at the bottom would be the example
to follow, and maybe some more code to extract from and share.

- That /should/ only leave the really old analog TV and similar horrors
leftover. For those we simply can't even guess the right amount of
overscan (because back then no one cared back then about really seeing
everything), and so that's the only case where we should rely on the
overscan properties. And that case only works when the compositor stack
passes these properties all the way to the user, since only they can
check when the settings are good.

The overscan properties should _not_ be used to fix issues of the previous
kind, that really should all work out of the box as much as possible.

Cheers, Sima

> ---
> Michael Riesch (4):
> dt-bindings: vendor-prefixes: add jasonic
> dt-bindings: display: st7789v: add jasonic jt240mhqs-hwt-ek-e3 display
> drm/panel: sitronix-st7789v: add support for partial mode
> drm/panel: sitronix-st7789v: add jasonic jt240mhqs-hwt-ek-e3 support
> .../bindings/display/panel/sitronix,st7789v.yaml | 1 +
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 67 +++++++++++++++++++++-
> 3 files changed, 68 insertions(+), 2 deletions(-)
> ---
> base-commit: b43dae411767f34288aa347f26b5ed2dade39469
> change-id: 20230718-feature-lcd-panel-26d9f29a7830
> Best regards,
> --
> Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>

Daniel Vetter
Software Engineer, Intel Corporation