Re: [PATCH] rtc: rtc-pm8xxx: control default alarm wake up capability

From: Anvesh Jain P
Date: Tue Aug 01 2023 - 08:49:02 EST

In automotive systems, RTC should not wake up the device when it is parked or when it is garage to avoid leakage current. providing a control from device tree to avoid RTC wake up based on the use case is reason for this patch.

On 8/1/2023 6:10 PM, Alexandre Belloni wrote:
On 01/08/2023 17:15:49+0530, Anvesh Jain P wrote:
Enable & disable rtc alarm wake up capability based on
default parameter passed from device tree.

I see what you are doing but not why this is necessary, NAK.

Signed-off-by: Venkata Rao Kakani <quic_vkakani@xxxxxxxxxxx>
Signed-off-by: Anvesh Jain P <quic_ajainp@xxxxxxxxxxx>
drivers/rtc/rtc-pm8xxx.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index f6b779c12ca7..bed57be602b6 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -523,6 +523,9 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)
if (rc)
return rc;
+ if (of_property_read_bool(pdev->dev.of_node, "disable-alarm-wakeup"))
+ device_set_wakeup_capable(&pdev->dev, false);
rc = dev_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq);
if (rc)
return rc;

base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd