Re: [PATCH next] mmc: sunplus: Fix error handling in spmmc_drv_probe()

From: Dan Carpenter
Date: Tue Aug 01 2023 - 01:49:12 EST

On Mon, Jul 31, 2023 at 10:23:20PM -0700, Harshit Mogalapalli wrote:
> There are few issues in spmmc_drv_probe():
> 1. When mmc allocation fails, goto is a no-op.
> 2. When mmc allocation succeeds, the error paths should use goto instead
> of direct return.
> 3. platform_get_irq() doesn't return zero, so '<' is sufficient.
> Fix the above issues by adding goto instead of direct return, also
> remove NULL check in 'probe_free_host' as we changed the goto to return
> when mmc_alloc_host() fails.
> Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes:
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> ---


Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

dan carpenter