Re: [PATCH net-next v2] netconsole: Enable compile time configuration

[Jakub Kicinski]

On Mon, 31 Jul 2023 01:35:41 -0700 Breno Leitao wrote:
> +config NETCONSOLE_EXTENDED_LOG
> +	bool "Set kernel extended message as default"
> +	depends on NETCONSOLE
> +	default n
> +	help
> +	  Set extended log support for netconsole message. If this option is
> +	  set, log messages are transmitted with extended metadata header in a
> +	  format similar to /dev/kmsg.  See
> +	  <file:Documentation/networking/netconsole.rst> for details.
> +
> +config NETCONSOLE_PREPEND_RELEASE
> +	bool "Prepend kernel release version in the message"

... by default

> +	depends on NETCONSOLE_EXTENDED_LOG
> +	default n
> +	help
> +	  Set kernel release to be prepended to each netconsole message by
> +	  default. If this option is set, the kernel release is prepended into
> +	  the first field of every netconsole message, so, the netconsole
> +	  server/peer can easily identify what kernel release is logging each
> +	  message.  See <file:Documentation/networking/netconsole.rst> for
> +	  details.

I had to look at the code to see what this does, exactly.

I think you either need to make similar changes to
make_netconsole_target() so that instances created via sysfs
have the same default.

Or rewrite the help message to talk about forcing kernel
command line arguments, rather than setting defaults.
-- 
pw-bot: cr