Re: [PATCH] PSI: select KERNFS as needed

[Randy Dunlap]

On 7/31/23 11:17, Suren Baghdasaryan wrote:
> On Mon, Jul 31, 2023 at 11:14 AM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>>
>> On Sun, Jul 30, 2023 at 8:07 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>>>
>>> Users of KERNFS should select it to enforce its being built, so
>>> do this to prevent a build error.
>>>
>>> In file included from ../kernel/sched/build_utility.c:97:
>>> ../kernel/sched/psi.c: In function 'psi_trigger_poll':
>>> ../kernel/sched/psi.c:1479:17: error: implicit declaration of function 'kernfs_generic_poll' [-Werror=implicit-function-declaration]
>>>  1479 |                 kernfs_generic_poll(t->of, wait);
>>>
>>> Fixes: aff037078eca ("sched/psi: use kernfs polling functions for PSI trigger polling")
>>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> 
> shouldn't this include:
> Closes: https://lore.kernel.org/oe-kbuild-all/202307310732.r65EQFY0-lkp@xxxxxxxxx/
> ?
> 

That's the same URL as the Link: below.
The difference(s) in Closes: and Link: are not clear to me,
other than Closes: is newer.

>>> Link: lore.kernel.org/r/202307310732.r65EQFY0-lkp@xxxxxxxxx
>>> Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
>>> Cc: Suren Baghdasaryan <surenb@xxxxxxxxxx>
>>> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>>> Cc: Juri Lelli <juri.lelli@xxxxxxxxxx>
>>> Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
>>
>> Acked-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
>>
>> Thanks!
>>
>>
>>> ---
>>>  init/Kconfig |    1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff -- a/init/Kconfig b/init/Kconfig
>>> --- a/init/Kconfig
>>> +++ b/init/Kconfig
>>> @@ -629,6 +629,7 @@ config TASK_IO_ACCOUNTING
>>>
>>>  config PSI
>>>         bool "Pressure stall information tracking"
>>> +       select KERNFS
>>>         help
>>>           Collect metrics that indicate how overcommitted the CPU, memory,
>>>           and IO capacity are in the system.

-- 
~Randy