Re: [PATCH] cxl/mbox: Fix debug message print

From: Verma, Vishal L
Date: Mon Jul 31 2023 - 18:25:48 EST


On Mon, 2023-07-31 at 15:12 -0700, Dan Williams wrote:
> Ira Weiny wrote:
> > The handle value used to report an event being cleared by dev_dbg() is
> > incorrect due to a post increment of the payload handle index.
> >
> > Delay the increment of the index until after the print.  Also add the
> > debugging for event processing which was useful in finding this bug.
> >
> > To: Davidlohr Bueso <dave@xxxxxxxxxxxx>
> > To: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>
> > To: Dave Jiang <dave.jiang@xxxxxxxxx>
> > To: Alison Schofield <alison.schofield@xxxxxxxxx>
> > To: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> > To: Dan Williams <dan.j.williams@xxxxxxxxx>
>
> Is this some new process recommendation to use "To:", I would only
> expect Cc: for maintainers.
>
> > Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> Jonathan gets listed twice because?
>
> > Cc: linux-cxl@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
>
> I assume this is because b4 takes its address from the patch itself?
>
> It just feels a bit too noisy.

Yes - but the better way to do this is to add the To: and Cc: lines in
b4 prep --edit-cover, even for a single patch branch. That way b4 uses
them to figure out where to send/cc, but other doesn't add them to
commit messages (or even the cover letter in case there is one).