Re: [PATCH v3 07/42] soc: Add SoC driver for Cirrus ep93xx

From: Andy Shevchenko
Date: Mon Jul 31 2023 - 16:16:48 EST


On Fri, Jul 28, 2023 at 01:01:11PM +0300, Nikita Shubin wrote:
> On Fri, 2023-07-28 at 12:46 +0300, Andy Shevchenko wrote:

...

> I see your point now - citing docs:
>
> "Logic safeguards are included to condition the control signals for
> power connection to the matrix to prevent part damage. In addition, a
> software lock register is included that must be written with 0xAA
> before each register write to change the values of the four switch
> matrix control registers."
>
> So reading SHOULDN'T affect the lock.
>
> But as we checked reading also breaks the lock, that's why this looks
> so odd, it was done for purpose - i'll check it once again anyway.

This is very interesting information! Please, document this somewhere in
the code.

--
With Best Regards,
Andy Shevchenko