Re: [PATCH] nvme: Don't fail to resume if NSIDs change

From: Christoph Hellwig
Date: Mon Jul 31 2023 - 16:11:14 EST


On Mon, Jul 31, 2023 at 03:09:08PM -0500, Limonciello, Mario wrote:
> So is it reasonable to just add a check for
>
> ctrl->oacs & NVME_CTRL_OACS_NS_MNGT_SUPP
>
> In the same error handling path as this patch?

No. There are tons of NVMe devices that only support creating and
deleting namespace out of band, especially in virtualized and cloud
setups.