Re: [PATCH v1] scsi: be2iscsi: Add length check when parsing nlattrs

From: Martin K. Petersen
Date: Mon Jul 31 2023 - 15:45:24 EST


On Sun, 23 Jul 2023 15:59:38 +0800, Lin Ma wrote:

> beiscsi_iface_set_param parses nlattr with nla_for_each_attr and assumes
> every attributes can be viewed as struct iscsi_iface_param_info.
>
> This is not true because there is no any nla_policy to validate the
> attributes passed from the upper function iscsi_set_iface_params.
>
> This patch adds the nla_len check before accessing the nlattr data and
> error return EINVAL if the length check fails.
>
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: be2iscsi: Add length check when parsing nlattrs
https://git.kernel.org/mkp/scsi/c/ee0268f230f6

--
Martin K. Petersen Oracle Linux Engineering