Re: ksys_sync_helper

From: Wysocki, Rafael J
Date: Mon Jul 31 2023 - 14:27:38 EST


On 7/31/2023 9:20 AM, Christoph Hellwig wrote:
Guys,

why did b5dee3130bb4014 add a magic export for sync functionality
that wrapps VFS code in a weird way, and then exports it (without
even adding a user in that commit)? This kind of functionality
needs to be exported from the VFS, and only with ACKs?

OK, I'll remember about this.


With this
and commit d5ea093eebf022e now we end up with a random driver (amdgpu)
syncing all file systems for absolutely no good reason.

Sorry about that.

The problematic commit should still revert more or less cleanly, so please do that if that's what you need.