Re: [PATCH v1 1/1] test_firmware: prevent race conditions by a correct implementation of locking

From: Luis Chamberlain
Date: Mon Jul 31 2023 - 13:27:35 EST


On Mon, Jul 31, 2023 at 06:50:19PM +0200, Mirsad Todorovac wrote:
> NOTE: This patch is tested against 5.4 stable
>
> NOTE: This is a patch for the 5.4 stable branch, not for the torvalds tree.
>
> The torvalds tree, and stable tree 5.10, 5.15, 6.1 and 6.4 branches
> were fixed in the separate
> commit ID 4acfe3dfde68 ("test_firmware: prevent race conditions by a correct implementation of locking")
> which was incompatible with 5.4
>

The above part is not part of the original commit, you also forgot to
mention the upstream commit:


[ Upstream commit 4acfe3dfde685a5a9eaec5555351918e2d7266a1 ]

> Fixes: c92316bf8e948 ("test_firmware: add batched firmware tests")
> Cc: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Russ Weight <russell.h.weight@xxxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxx>
> Cc: Tianfei Zhang <tianfei.zhang@xxxxxxxxx>
> Cc: Shuah Khan <shuah@xxxxxxxxxx>
> Cc: Colin Ian King <colin.i.king@xxxxxxxxx>
> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: linux-kselftest@xxxxxxxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx # v5.4
> Suggested-by: Dan Carpenter <error27@xxxxxxxxx>

Here you can add the above note in brackets:

[ explain your changes here from the original commit ]

Then, I see two commits upstream on Linus tree which are also fixes
but not merged on v5.4, did you want those applied too?

Luis