Re: [PATCH v1 04/14] futex: Validate futex value against futex size

From: Thomas Gleixner
Date: Mon Jul 31 2023 - 13:16:06 EST


On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote:
> +static inline bool futex_validate_input(unsigned int flags, u64 val)
> +{
> + int bits = 8 * futex_size(flags);
> + if (bits < 64 && (val >> bits))

New line between declaration and code.

> + return false;
> + return true;
> +}

Other than that::

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>