Re: [PATCH v2 2/2] nvme-auth: set explanation code for failure2 msgs

[Hannes Reinecke]

On 7/31/23 16:51, Mark O'Donovan wrote:
> Some error cases were not setting an auth-failure-reason-code-explanation.
> This means an AUTH_Failure2 message will be sent with an explanation value
> of 0 which is a reserved value.
>
> Signed-off-by: Mark O'Donovan <shiftee@xxxxxxxxxx>
> ---
> v1->v2: Set failure explanation in a single place if the error handling
> code has not already done so.
>
>   drivers/nvme/host/auth.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
> index e1a98647c3a2..9556cfc4f5f3 100644
> --- a/drivers/nvme/host/auth.c
> +++ b/drivers/nvme/host/auth.c
> @@ -839,6 +839,8 @@ static void nvme_queue_auth_work(struct work_struct *work)
>   	}
>   
>   fail2:
> +	if (chap->status == 0)
> +		chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED;
>   	dev_dbg(ctrl->device, "%s: qid %d send failure2, status %x\n",
>   		__func__, chap->qid, chap->status);
>   	tl = nvme_auth_set_dhchap_failure2_data(ctrl, chap);

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman