Error 'netif_napi_add_weight() called with weight 256'

From: Limonciello, Mario
Date: Mon Jul 31 2023 - 12:03:19 EST


Hi,

I noticed today with 6.5-rc4 and also on 6.1.42 that I'm getting an error from an r8152 based dongle (Framework ethernet expansion card).

netif_napi_add_weight() called with weight 256

It seems that this message is likely introduced by
8ded532cd1cbe ("r8152: switch to netif_napi_add_weight()")

which if the card has support_2500full set will program the value to 256:

netif_napi_add_weight(netdev, &tp->napi, r8152_poll,
tp->support_2500full ? 256 : 64);

It's err level from
82dc3c63c692b ("net: introduce NAPI_POLL_WEIGHT")

Why is this considered an error but the driver uses the bigger value?
Should it be downgraded to a warning?

Thanks,