Re: [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb

From: Christian Brauner
Date: Mon Jul 31 2023 - 10:03:54 EST


On Mon, Jul 31, 2023 at 03:53:25PM +0200, Christoph Hellwig wrote:
> On Mon, Jul 31, 2023 at 03:22:28PM +0200, Christian Brauner wrote:
> > Uh, no. I vasty underestimated how sensitive that change would be. Plus
> > arguably ->kill_sb() really should be callable once the sb is visible.
> >
> > Are you looking into this or do you want me to, Christoph?
>
> I'm planning to look into it, but I won't get to it before tomorrow.

Ok, let me go through the callsites and make sure that all callers are
safe. I think we should just continue calling deactivate_locked_super()
exactly the way we do right now but remove shenanigans like the one we
have in erofs_kill_sb().