Re: [patch V2 16/58] x86/apic: Sanitize num_processors handling

[Thomas Gleixner]

On Mon, Jul 31 2023 at 12:17, Juergen Gross wrote:
> On 24.07.23 15:34, Thomas Gleixner wrote:
> This is introducing a regression for Xen PV guests: those have no ACPI
> tables, so smp_found_config will be 0. OTOH num_processors has been set
> already using hypervisor data, so setting num_processors to 1 here will
> overwrite the previous setting.
>
> Below diff on top is fixing the problem:

Fixing? You can't be serious about that.

Why can't XENPV pretend that it has a smp configuration detected,
i.e. setting smp_found_config as any other special get_smp_config()
implementation does?

XENPV is already a major pain to deal with. No need to expand the
related insanity all over the place.

Thanks,

        tglx