Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply

From: Guido Günther
Date: Mon Jul 31 2023 - 07:50:30 EST


Hi,
On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote:
> Resolves following warning:
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
>
> Cc: kernel@xxxxxxx
> Cc: Guido Günther <agx@xxxxxxxxxxx>
> Signed-off-by: David Heidelberg <david@xxxxxxx>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index b3549eae6278..a8b5da3ca08f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -1031,7 +1031,7 @@ &usdhc2 {
> pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
> bus-width = <4>;
> vmmc-supply = <&reg_usdhc2_vmmc>;
> - power-supply = <&wifi_pwr_en>;
> + vqmmc-supply = <&wifi_pwr_en>;

>From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE`
so I don't think vqmmc is correct here. I wonder if there's a better way
to model that in DT? Any suggestions would be welcome.

Cheers,
-- Guido

> broken-cd;
> disable-wp;
> cap-sdio-irq;
> --
> 2.40.1
>