Re: [PATCH] firmware: meson_sm: fix to avoid potential NULL pointer dereference

[neil . armstrong]

On 15/07/2023 16:13, Zhang Shurong wrote:
> of_match_device() may fail and returns a NULL pointer.
>
> Fix this by checking the return value of of_match_device.
>
> Fixes: 8cde3c2153e8 ("firmware: meson_sm: Rework driver as a proper platform driver")
> Signed-off-by: Zhang Shurong <zhang_shurong@xxxxxxxxxxx>
> ---
>   drivers/firmware/meson/meson_sm.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c
> index 798bcdb05d84..9a2656d73600 100644
> --- a/drivers/firmware/meson/meson_sm.c
> +++ b/drivers/firmware/meson/meson_sm.c
> @@ -292,6 +292,8 @@ static int __init meson_sm_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	chip = of_match_device(meson_sm_ids, dev)->data;
> +	if (!chip)
> +		return -EINVAL;
>   
>   	if (chip->cmd_shmem_in_base) {
>   		fw->sm_shmem_in_base = meson_sm_map_shmem(chip->cmd_shmem_in_base,


Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>