Re: [PATCH 2/2] nvme-auth: set explanation code for failure2 msgs

From: Christoph Hellwig
Date: Mon Jul 31 2023 - 01:58:14 EST


On Thu, Jul 27, 2023 at 01:47:48PM +0000, Mark O'Donovan wrote:
> These error cases were not setting an auth-failure-reason-code-explanation.
> This means an AUTH_Failure2 message will be sent with an explanation value
> of 0 which is a reserved value.

I'll leave the final decision to Hannes, but shouldn't we find a common
place, either behind a label or in the body of the function to set
chap->status? Having to add this in a lot of error labels doesn't feel
very maintainable.