Re: [PATCH v4 09/11] remoteproc: qcom: Add Hexagon based multipd rproc driver

[Manikanta Mylavarapu]

On 7/28/2023 1:57 PM, Krzysztof Kozlowski wrote:
> On 28/07/2023 08:34, Manikanta Mylavarapu wrote:
> > +
> > +static int q6_get_inbound_irq(struct qcom_q6v5 *q6,
> > +			      struct platform_device *pdev,
> > +			      const char *int_name,
> > +			      int index, int *pirq,
> > +			      irqreturn_t (*handler)(int irq, void *data))
> > +{
> > +	int ret, irq;
> > +	char *interrupt, *tmp = (char *)int_name;
> > +	struct q6_wcss *wcss = q6->rproc->priv;
> > +
> > +	irq = platform_get_irq(pdev, index);
> > +	if (irq < 0) {
> > +		if (irq != -EPROBE_DEFER)
>
> Still not good... I think I am saying this the third time: drop this
> eprobe defer dance. It is not needed. Just open the definition of
> dev_err_probe().
Yeah, somehow it's missed. I will drop.

Thanks & Regards,
Manikanta.

> > +			return dev_err_probe(&pdev->dev, irq,
> > +					     "failed to retrieve %s IRQ: %d\n",
> > +					     int_name, irq);
> > +	}
> > +
>
>
>
> Best regards,
> Krzysztof