Re: [PATCH] vduse: Use proper spinlock for IRQ injection

From: Yongji Xie
Date: Sun Jul 30 2023 - 22:25:24 EST


On Wed, Jul 5, 2023 at 7:45 PM Maxime Coquelin
<maxime.coquelin@xxxxxxxxxx> wrote:
>
> The IRQ injection work used spin_lock_irq() to protect the
> scheduling of the softirq, but spin_lock_bh() should be
> used.
>
> With spin_lock_irq(), we noticed delay of more than 6
> seconds between the time a NAPI polling work is scheduled
> and the time it is executed.
>
> Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
> Cc: xieyongji@xxxxxxxxxxxxx
>
> Suggested-by: Jason Wang <jasowang@xxxxxxxxxx>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@xxxxxxxxxx>

Reviewed-by: Xie Yongji <xieyongji@xxxxxxxxxxxxx>

Thanks,
Yongji