Re: [PATCH] scsi:libsas: Simplify sas_queue_reset and remove unused code

From: Jason Yan
Date: Sun Jul 30 2023 - 21:44:52 EST


Hi Wenchao,

On 2023/7/29 18:24, Wenchao Hao wrote:
sas_queue_reset is always called with param "wait" set to 0, so
remove it from this function's param list. And remove unused
function sas_wait_eh.

I did not find any users passing '1' to sas_queue_reset() in the git history. It seems it is never used. So It's ok to remove it, I guess.

Just one nit, there should be a blank between "scsi:" and "libsas" in the subject:

scsi: libsas: Simplify sas_queue_reset and remove unused code

Otherwise looks good to me:
Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>