Re: [PATCH v2 resend 2] drm/armada: Fix off-by-one error in armada_overlay_get_property()

From: Javier Martinez Canillas
Date: Sat Jul 29 2023 - 15:15:53 EST


Geert Uytterhoeven <geert+renesas@xxxxxxxxx> writes:

> As ffs() returns one more than the index of the first bit set (zero
> means no bits set), the color key mode value is shifted one position too
> much.
>
> Fix this by using FIELD_GET() instead.
>
> Fixes: c96103b6c49ff9a8 ("drm/armada: move colorkey properties into overlay plane state")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> ---
> Compile-tested only.
>
> v2:
> - Add Reviewed-by.
> ---

Pushed to drm-misc (drm-misc-next). Thanks!

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat