Re: [PATCH net-next] net: ethernet: mtk_eth_soc: support per-flow accounting on MT7988
From: kernel test robot
Date: Sat Jul 29 2023 - 14:17:03 EST
Hi Daniel,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Golle/net-ethernet-mtk_eth_soc-support-per-flow-accounting-on-MT7988/20230729-215634
base: net-next/main
patch link: https://lore.kernel.org/r/801c89963e95e5ce8f1ab7dbda894dd9da0125cc.1690638748.git.daniel%40makrotopia.org
patch subject: [PATCH net-next] net: ethernet: mtk_eth_soc: support per-flow accounting on MT7988
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230730/202307300133.j8MIsDCa-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230730/202307300133.j8MIsDCa-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307300133.j8MIsDCa-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/net/ethernet/mediatek/mtk_ppe.c: In function 'mtk_mib_entry_read':
>> drivers/net/ethernet/mediatek/mtk_ppe.c:112:17: error: 'bytes_cnt_low' undeclared (first use in this function); did you mean 'byte_cnt_low'?
112 | bytes_cnt_low = cnt_r0;
| ^~~~~~~~~~~~~
| byte_cnt_low
drivers/net/ethernet/mediatek/mtk_ppe.c:112:17: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ethernet/mediatek/mtk_ppe.c:113:17: error: 'bytes_cnt_high' undeclared (first use in this function); did you mean 'byte_cnt_high'?
113 | bytes_cnt_high = cnt_r1;
| ^~~~~~~~~~~~~~
| byte_cnt_high
vim +112 drivers/net/ethernet/mediatek/mtk_ppe.c
92
93 static int mtk_mib_entry_read(struct mtk_ppe *ppe, u16 index, u64 *bytes, u64 *packets)
94 {
95 u32 byte_cnt_low, byte_cnt_high, pkt_cnt_low, pkt_cnt_high;
96 u32 val, cnt_r0, cnt_r1, cnt_r2;
97 int ret;
98
99 val = FIELD_PREP(MTK_PPE_MIB_SER_CR_ADDR, index) | MTK_PPE_MIB_SER_CR_ST;
100 ppe_w32(ppe, MTK_PPE_MIB_SER_CR, val);
101
102 ret = mtk_ppe_mib_wait_busy(ppe);
103 if (ret)
104 return ret;
105
106 cnt_r0 = readl(ppe->base + MTK_PPE_MIB_SER_R0);
107 cnt_r1 = readl(ppe->base + MTK_PPE_MIB_SER_R1);
108 cnt_r2 = readl(ppe->base + MTK_PPE_MIB_SER_R2);
109
110 if (mtk_is_netsys_v3_or_greater(ppe->eth)) {
111 /* 64 bit for each counter */
> 112 bytes_cnt_low = cnt_r0;
> 113 bytes_cnt_high = cnt_r1;
114 pkt_cnt_low = cnt_r2;
115 pkt_cnt_high = readl(ppe->base + MTK_PPE_MIB_SER_R3);
116 } else {
117 /* 48 bit for each counter */
118 byte_cnt_low = FIELD_GET(MTK_PPE_MIB_SER_R0_BYTE_CNT_LOW, cnt_r0);
119 byte_cnt_high = FIELD_GET(MTK_PPE_MIB_SER_R1_BYTE_CNT_HIGH, cnt_r1);
120 pkt_cnt_low = FIELD_GET(MTK_PPE_MIB_SER_R1_PKT_CNT_LOW, cnt_r1);
121 pkt_cnt_high = FIELD_GET(MTK_PPE_MIB_SER_R2_PKT_CNT_HIGH, cnt_r2);
122 }
123
124 *bytes = ((u64)byte_cnt_high << 32) | byte_cnt_low;
125 *packets = (pkt_cnt_high << 16) | pkt_cnt_low;
126
127 return 0;
128 }
129
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki