Re: [PATCH v2 1/2] dt-bindings: mt76: support setting per-band MAC address

From: Conor Dooley
Date: Sat Jul 29 2023 - 06:11:00 EST


On Fri, Jul 28, 2023 at 03:50:47AM +0100, Daniel Golle wrote:
> Introduce support for setting individual per-band MAC addresses using
> NVMEM cells by adding a 'bands' object with enumerated child nodes
> representing the 2.4 GHz, 5 GHz and 6 GHz bands.
>
> In case it is defined, call of_get_mac_address for the per-band child
> node, otherwise try with of_get_mac_address on the main device node and
> fall back to a random address like it used to be.
>
> While at it, add MAC address related properties also for the main node
> and update example to use EEPROM via nvmem-cells instead of deprecated
> mediatek,mtd-eeprom property.

Could you mark that deprecated then please?

> +patternProperties:
> + '^band@[0-2]+$':
> + type: object
> + additionalProperties: false
> + properties:
> + reg:
> + maxItems: 1
> +
> + address: true
> + local-mac-address: true
> + mac-address: true
> +
> + nvmem-cells:
> + description: NVMEM cell with the MAC address
> +
> + nvmem-cell-names:
> + items:
> + - const: mac-address

You should not need the items list if you only have one item.

0

Attachment: signature.asc
Description: PGP signature