Re: [PATCH 1/4] interconnect: qcom: icc-rpm: Add AB/IB calculations coefficients
From: kernel test robot
Date: Sat Jul 29 2023 - 05:25:28 EST
Hi Konrad,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 1e25dd7772483f477f79986d956028e9f47f990a]
url: https://github.com/intel-lab-lkp/linux/commits/Konrad-Dybcio/interconnect-qcom-icc-rpm-Add-AB-IB-calculations-coefficients/20230727-002710
base: 1e25dd7772483f477f79986d956028e9f47f990a
patch link: https://lore.kernel.org/r/20230726-topic-icc_coeff-v1-1-31616960818c%40linaro.org
patch subject: [PATCH 1/4] interconnect: qcom: icc-rpm: Add AB/IB calculations coefficients
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20230729/202307291745.0JcdYvBz-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291745.0JcdYvBz-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307291745.0JcdYvBz-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/interconnect/qcom/icc-rpm.c: In function 'qcom_icc_bus_aggregate':
>> drivers/interconnect/qcom/icc-rpm.c:302:27: warning: variable 'agg_peak_rate' set but not used [-Wunused-but-set-variable]
302 | u64 agg_avg_rate, agg_peak_rate, agg_rate;
| ^~~~~~~~~~~~~
vim +/agg_peak_rate +302 drivers/interconnect/qcom/icc-rpm.c
293
294 /**
295 * qcom_icc_bus_aggregate - calculate bus clock rates by traversing all nodes
296 * @provider: generic interconnect provider
297 * @agg_clk_rate: array containing the aggregated clock rates in kHz
298 */
299 static void qcom_icc_bus_aggregate(struct icc_provider *provider, u64 *agg_clk_rate)
300 {
301 struct qcom_icc_provider *qp = to_qcom_provider(provider);
> 302 u64 agg_avg_rate, agg_peak_rate, agg_rate;
303 struct qcom_icc_node *qn;
304 struct icc_node *node;
305 u16 percent;
306 int i;
307
308 /*
309 * Iterate nodes on the provider, aggregate bandwidth requests for
310 * every bucket and convert them into bus clock rates.
311 */
312 list_for_each_entry(node, &provider->nodes, node_list) {
313 qn = node->data;
314 for (i = 0; i < QCOM_SMD_RPM_STATE_NUM; i++) {
315 if (qn->channels)
316 agg_avg_rate = div_u64(qn->sum_avg[i], qn->channels);
317 else
318 agg_avg_rate = qn->sum_avg[i];
319
320 percent = qp->ab_percent ? qp->ab_percent : 100;
321 agg_avg_rate = mult_frac(percent, agg_avg_rate, 100);
322
323 percent = qn->ib_percent ? qn->ib_percent : 100;
324 agg_peak_rate = mult_frac(percent, qn->max_peak[i], 100);
325
326 agg_rate = max_t(u64, agg_avg_rate, qn->max_peak[i]);
327 do_div(agg_rate, qn->buswidth);
328
329 agg_clk_rate[i] = max_t(u64, agg_clk_rate[i], agg_rate);
330 }
331 }
332 }
333
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki