Re: [PATCH v3] of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock

From: kernel test robot
Date: Sat Jul 29 2023 - 02:20:36 EST


Hi Rob,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.5-rc3 next-20230728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Rob-Herring/of-dynamic-Refactor-action-prints-to-not-use-pOF-inside-devtree_lock/20230729-072155
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20230728231950.1619073-1-robh%40kernel.org
patch subject: [PATCH v3] of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock
config: powerpc-randconfig-r014-20230728 (https://download.01.org/0day-ci/archive/20230729/202307291420.tIsNBqGH-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291420.tIsNBqGH-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307291420.tIsNBqGH-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/of/dynamic.c:74:6: warning: no previous prototype for function 'of_changeset_action_print' [-Wmissing-prototypes]
void of_changeset_action_print(unsigned long action, struct device_node *np, const char *prop_name)
^
drivers/of/dynamic.c:74:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void of_changeset_action_print(unsigned long action, struct device_node *np, const char *prop_name)
^
static
1 warning generated.


vim +/of_changeset_action_print +74 drivers/of/dynamic.c

73
> 74 void of_changeset_action_print(unsigned long action, struct device_node *np, const char *prop_name)
75 {
76 if (prop_name)
77 pr_cont("%-15s %pOF:%s\n", action_names[action], np, prop_name);
78 else
79 pr_cont("%-15s %pOF\n", action_names[action], np);
80 }
81

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki