Re: [PATCH v3 1/1] net: gro: fix misuse of CB in udp socket lookup

[David Ahern]

On 7/27/23 9:33 AM, Richard Gobert wrote:
> This patch fixes a misuse of IP{6}CB(skb) in GRO, while calling to
> `udp6_lib_lookup2` when handling udp tunnels. `udp6_lib_lookup2` fetch the
> device from CB. The fix changes it to fetch the device from `skb->dev`.
> l3mdev case requires special attention since it has a master and a slave
> device.
> 
> Fixes: a6024562ffd7 ("udp: Add GRO functions to UDP socket")
> Reported-by: Gal Pressman <gal@xxxxxxxxxx>
> Signed-off-by: Richard Gobert <richardbgobert@xxxxxxxxx>
> ---
>  include/net/gro.h      | 43 ++++++++++++++++++++++++++++++++++++++++++
>  net/ipv4/udp.c         |  8 ++++++--
>  net/ipv4/udp_offload.c |  7 +++++--
>  net/ipv6/udp.c         |  8 ++++++--
>  net/ipv6/udp_offload.c |  7 +++++--
>  5 files changed, 65 insertions(+), 8 deletions(-)
> 

I still think the text in the cover letter should be in this commit message.

Code wise, it looks ok to me:
Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>