Re: [PATCH next 3/3] selftests:connector: Add root check and fix arg error paths to skip

[Shuah Khan]

On 7/28/23 12:10, Anjali Kulkarni wrote:
> > On Jul 28, 2023, at 10:29 AM, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > proc_filter test requires root privileges. Add root privilege check
> > and skip the test. Also fix argument parsing paths to skip in their
> > error legs.
> >
> > Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> > ---
> > tools/testing/selftests/connector/proc_filter.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c
> > index 4fe8c6763fd8..7b2081b98e5c 100644
> > --- a/tools/testing/selftests/connector/proc_filter.c
> > +++ b/tools/testing/selftests/connector/proc_filter.c
> > @@ -248,7 +248,7 @@ int main(int argc, char *argv[])
> >
> > 	if (argc > 2) {
> > 		printf("Expected 0(assume no-filter) or 1 argument(-f)\n");
> > -		exit(1);
> > +		exit(KSFT_SKIP);
> > 	}
> >
> > 	if (argc == 2) {
> > @@ -256,10 +256,15 @@ int main(int argc, char *argv[])
> > 			filter = 1;
> > 		} else {
> > 			printf("Valid option : -f (for filter feature)\n");
> > -			exit(1);
> > +			exit(KSFT_SKIP);
> > 		}
> > 	}
> >
> > +	if (geteuid()) {
> > +		printf("Connector test requires root privileges.\n");
> > +		exit(KSFT_SKIP);
> > +	}
> > +
>
> I am not sure why you have added this check? proc_filter does not need root privilege to run.

It failed for me when I ran it saying it requires root privileges.
I had to run it as root.

thanks,
-- Shuah